chesnokoff commented on code in PR #12301:
URL: https://github.com/apache/ignite/pull/12301#discussion_r2324309536
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -1703,10 +1704,24 @@ private boolean notifyDiscovery(int type, long topVer,
TcpDiscoveryNode node, Sp
NavigableMap<Long, Collection<ClusterNode>> hist =
updateTopologyHistory(topVer, top);
- lsnr.onDiscovery(
+ IgniteFuture<?> fut = lsnr.onDiscovery(
Review Comment:
The future is responsible for updating `discovery().allNodes()` that is used
in `allowedMinorVersions` so we need to wait it. Otherwise, there is race
codition, when we can accept +1 and -1 version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
