AMashenkov commented on code in PR #6593:
URL: https://github.com/apache/ignite-3/pull/6593#discussion_r2379389121
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##########
@@ -984,4 +1320,30 @@ boolean matches() {
return matches;
}
}
+
+ static class PlanInfo {
+ private final QueryPlan queryPlan;
+ @Nullable private final ValidStatement<ValidationResult> statement;
+ @Nullable private final PlanningContext context;
Review Comment:
I don't like the idea caching PlanningContext instance.
It can barely reused, and contains too much data.
Ideally, all information should be restored from cache key.
Also, I see we never need query parameters at planning stage, but just
`isNull`-flag and parameter type.
Let's create a ticket to drop values from DynamicParamState.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
