zstan commented on code in PR #6593:
URL: https://github.com/apache/ignite-3/pull/6593#discussion_r2381181741
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##########
@@ -984,4 +1320,30 @@ boolean matches() {
return matches;
}
}
+
+ static class PlanInfo {
+ private final QueryPlan queryPlan;
+ @Nullable private final ValidStatement<ValidationResult> statement;
+ @Nullable private final PlanningContext context;
Review Comment:
1. good catch, but i not agree to re-create PlanningContext from CacheKey
info, cause regardless _boolean explicitTx_ plans can be the same, i implement
lighter parameters holder for further PlanningContext building.
2. We gather _paramTypes_ only once during CacheKey creation, thus i don`t
see a problem here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
