alievmirza commented on code in PR #6651:
URL: https://github.com/apache/ignite-3/pull/6651#discussion_r2419433692
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -613,8 +602,7 @@ private static String entryKeyAsString(EntryEvent entry) {
}
/**
- * Reaction on an update of logical topology. In this method {@link
DistributionZoneManager#logicalTopology},
- * {@link DistributionZoneManager#nodesAttributes} are updated.
+ * Reaction on an update of logical topology. In this method {@link
DistributionZoneManager#logicalTopology}.
Review Comment:
please improve javadoc
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DataNodesManager.java:
##########
@@ -1112,12 +1230,14 @@ CompletableFuture<?> onZoneCreate(
notTombstone(zoneDataNodesHistoryKey(zoneId))
);
- Update update = ops(
+ Update update = new Operations(operations(
addNewEntryToDataNodesHistory(zoneId, new
DataNodesHistory(), timestamp, dataNodes),
clearTimer(zoneScaleUpTimerKey(zoneId)),
clearTimer(zoneScaleDownTimerKey(zoneId)),
- clearTimer(zonePartitionResetTimerKey(zoneId))
- ).yield(true);
+ clearTimer(zonePartitionResetTimerKey(zoneId)),
+ removeLegacyDataNodes ? remove(zoneDataNodesKey(zoneId)) :
noop(),
+ removeLegacyDataNodes ? remove(zonesNodesAttributes()) :
noop()
Review Comment:
`zonesNodesAttributes` also could be marked as Deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
