denis-chudov commented on code in PR #6651:
URL: https://github.com/apache/ignite-3/pull/6651#discussion_r2410970310
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DataNodesManager.java:
##########
@@ -258,7 +280,17 @@ CompletableFuture<Void> startAsync(
onScaleDownTimerChange(zone, scaleDownTimer);
restorePartitionResetTimer(zone.id(), scaleDownTimer,
recoveryRevision);
}
- });
+ })
+ .thenCompose(unused ->
allOf(legacyInitFutures.stream().map(IgniteBiTuple::getValue).collect(toList()))
+ .handle((v, e) -> {
+ if (e != null) {
+ LOG.error("Could not recover legacy data nodes
for zone.", e);
Review Comment:
I think we shouldn't trigger failure handler here. Cluster can be still
operational if something happens with one zone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
