timoninmaxim commented on code in PR #12356:
URL: https://github.com/apache/ignite/pull/12356#discussion_r2417438800


##########
modules/ducktests/README.md:
##########
@@ -11,6 +11,19 @@ Structure of the `tests` directory is:
 - `./ignitetest/tests` contains tests.
 - `./checks` contains unit tests of utils, tests' decorators etc. 
 
+Some tests (like the CDC replication ones) require modules maintained in the 
+separate [ignite-extensions](https://github.com/apache/ignite-extensions) 
repository.
+
+To run these tests the `ignite-extensions` working directory should be checked 
out
+to the same directory as the `${IGNITE_HOME}` one. The needed extension module 
should

Review Comment:
   > the `ignite-extensions` working directory should be checked out to the 
same directory as the `${IGNITE_HOME}`
   
   > cd ${IGNITE_HOME}\..\ignite-extensions
   
   The doc looks misleading.



##########
modules/ducktests/tests/docker/ducker-ignite:
##########
@@ -304,6 +304,12 @@ docker_run() {
         done
     fi
 
+    # Mount the ignite-extensions sources directory as well if it exists.
+    local mount_ignite_ext=""
+    if [[ -d "${ignite_dir}/../ignite-extensions" ]]; then
+        mount_ignite_ext="--mount 
type=bind,source="${ignite_dir}/../ignite-extensions",target=/opt/ignite-extensions,consistency=delegated"

Review Comment:
   I'm not sure but binding might fail with relative paths. Can we resolve 
directories to absolute paths and mount them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to