AMashenkov commented on code in PR #6695:
URL: https://github.com/apache/ignite-3/pull/6695#discussion_r2405638966


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CreateTableCommand.java:
##########
@@ -67,7 +67,10 @@ public static CreateTableCommandBuilder builder() {
 
     private final String zoneName;
 
-    private String storageProfile;
+    private final @Nullable String storageProfile;
+
+    private final double staleRowsFraction;
+    private final long minStaleRowsCount;

Review Comment:
   Does it make sense to wrap statistic related stuff into a class holder (like 
ColumnParams)?
   Just to reduce command code size and make it more structures. I assume there 
will be more options in addition to those 2 ones.
   Maybe, we even do not need supporting separate serializer for such class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to