tkalkirill commented on code in PR #6696:
URL: https://github.com/apache/ignite-3/pull/6696#discussion_r2405689534
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/CliIntegrationTest.java:
##########
@@ -69,6 +69,7 @@ public abstract class CliIntegrationTest extends
ClusterPerClassIntegrationTest
new MetricSource().name("sql.client").enabled(true),
new MetricSource().name("sql.plan.cache").enabled(true),
new MetricSource().name("sql.queries").enabled(true),
+ new MetricSource().name("storage.aipersist").enabled(true),
new MetricSource().name("storage.aipersist.default").enabled(true),
new
MetricSource().name("storage.aipersist.default_aipersist").enabled(true),
new
MetricSource().name("storage.aipersist.checkpoint").enabled(true),
Review Comment:
> What do storage.aipersist.* mean?
Depending on the context, for example, in this PR, a storage metric was
added.
> Is default a storage profile?
Yes.
> What will happen if I name a storage profile 'checkpoint', will metrics
clash?
More likely.
How do you propose to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
