ibessonov commented on code in PR #6881:
URL: https://github.com/apache/ignite-3/pull/6881#discussion_r2498786164
##########
modules/client/src/main/java/org/apache/ignite/internal/client/ClientTimeoutWorker.java:
##########
@@ -68,11 +68,11 @@ private synchronized void shutdownIfEmpty() {
}
}
- private static ScheduledExecutorService createExecutor() {
+ private static ScheduledExecutorService
createExecutor(IgniteClientConfiguration clientCfg) {
return Executors.newSingleThreadScheduledExecutor(
new NamedThreadFactory(
"TcpClientChannel-timeout-worker",
- Loggers.voidLogger()));
+ ClientUtils.logger(clientCfg,
ClientTimeoutWorker.class)));
Review Comment:
Please ask @ptupitsyn if that's a good change, I don't know much about the
code of Java client
##########
modules/client/src/main/java/org/apache/ignite/internal/client/io/netty/DefaultExceptionHandler.java:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.client.io.netty;
+
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.channel.ChannelInboundHandlerAdapter;
+import org.apache.ignite.client.IgniteClientConfiguration;
+import org.apache.ignite.internal.client.ClientUtils;
+import org.apache.ignite.internal.logger.IgniteLogger;
+
+/**
+ * Default Netty exception handler.
+ *
+ * <p>Intended to be the last inbound handler in a channel pipeline.
+ */
+class DefaultExceptionHandler extends ChannelInboundHandlerAdapter {
+ /** Logger. */
+ private final IgniteLogger log;
+
+ /**
+ * Constructor.
+ *
+ * @param clientCfg Client configuration.
+ */
+ DefaultExceptionHandler(IgniteClientConfiguration clientCfg) {
+ this.log = ClientUtils.logger(clientCfg,
DefaultExceptionHandler.class);
+ }
+
+ /** {@inheritDoc} */
Review Comment:
We don't do this in AI3, please remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
