vdmitrienko commented on PR #6881: URL: https://github.com/apache/ignite-3/pull/6881#issuecomment-3507913301
> No unlogged exceptions in disruptors? Yes, all `Disruptor` instances are created through `StripedDisruptor`. - Event-handling exceptions are properly handled in `StripedDisruptor.StripeExceptionHandler`. - Also, every `StripedDisruptor` constructor call, direct or indirect, receives an `IgniteThreadFactory` with a properly set uncaught exception handler. > Have you checked? Yes, I verified this by adding exceptions to events in unit tests such as `FSMCallerTest`, and checked that the exceptions are properly logged. For example: ``` [2025-11-09T11:09:29,646][ERROR][%test%TestFSMDisruptor_stripe_0-0][StripedDisruptor] Handle disruptor event error [name=%test%TestFSMDisruptor-, event=org.apache.ignite.raft.jraft.core.FSMCallerImpl$ApplyTask@212c45b7, hasHandler=false] ``` > I'm sure I saw them a few times. It’s possible this issue was fixed in https://github.com/apache/ignite-3/pull/5477 Since that PR, the `StripedDisruptor` constructor requires: ```java BiFunction<String, IgniteLogger, ThreadFactory> threadFactorySupplier ``` and `StripedDisruptor` usages were updated accordingly: ```java (stripeName, logger) -> NamedThreadFactory.create(opts.getServerName(), stripeName, true, logger), ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
