sk0x50 commented on code in PR #6977:
URL: https://github.com/apache/ignite-3/pull/6977#discussion_r2538252604


##########
modules/catalog-compaction/src/test/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunnerSelfTest.java:
##########
@@ -1255,7 +1248,6 @@ private CatalogCompactionRunner createRunner(
                 clockService,
                 schemaSyncService,
                 topologyService,
-                new SystemPropertiesNodeProperties(),

Review Comment:
   Yes, this is how it should be, at least as long as the implementation of 
`MinimumRequiredTimeCollectorService` is based on `TablePartitionId`. If I am 
not mistaken, we discussed this topic several months ago, when we were 
implementing the zone-based colocation feature.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to