Copilot commented on code in PR #7037:
URL: https://github.com/apache/ignite-3/pull/7037#discussion_r2549767783
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -98,19 +101,26 @@ Here is how you can commit a transaction:
// Open the JDBC connection.
Connection conn =
DriverManager.getConnection("jdbc:ignite:thin://127.0.0.1:10800");
+// Disable auto-commit mode.
+conn.setAutoCommit(false);
+
// Commit a transaction
conn.commit();
----
-You can also configure Apache Ignite to automatically commit transactions by
using the `setAutoCommit()` method.
-
Here is how you can rollback a transaction:
[source, java]
----
conn.rollback();
----
+== Partition awareness
+
+Partition awareness is supported by the JDBC driver.
+
+Check the link:developers-guide/clients/overview#partition-awareness[following
link] to learn more about partition awareness.
Review Comment:
[nitpick] The phrasing "Check the following link" could be improved for
better documentation style. Consider rephrasing to "For more information about
partition awareness, see the
link:developers-guide/clients/overview#partition-awareness[overview
documentation]." or simply "See
link:developers-guide/clients/overview#partition-awareness[Partition Awareness
Overview] for more details."
```suggestion
See link:developers-guide/clients/overview#partition-awareness[Partition
Awareness Overview] for more details.
```
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -89,7 +90,9 @@ If the same parameters are passed by using different means,
the JDBC driver prio
== Performing Transactions
-With the JDBC driver, you can perform `commit` and `rollback` transactions.
For more information about transactions, see
link:developers-guide/transactions[Performing Transactions].
+By default a JDBC connection is in auto-commit mode, in this mode all its SQL
statements will be executed and committed as individual transactions.
+To be able to manage the transaction, you must switch connection to
non-autocommit mode (see
link:https://docs.oracle.com/en/java/javase/11/docs/api/java.sql/java/sql/Connection.html#setAutoCommit(boolean)[java
documentation]).
+In non-autocommit mode, you can perform `commit` and `rollback` transactions.
For more information about transactions, see
link:developers-guide/transactions[Performing Transactions].
Review Comment:
There is a double space between "can" and "perform". It should be a single
space: "you can perform `commit`".
```suggestion
In non-autocommit mode, you can perform `commit` and `rollback`
transactions. For more information about transactions, see
link:developers-guide/transactions[Performing Transactions].
```
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -16,10 +16,10 @@
Apache Ignite is shipped with JDBC driver that allows processing of
distributed data using standard SQL statements like `SELECT`, `INSERT`,
`UPDATE`, or `DELETE` directly from the JDBC side. The name of the driver's
class is `org.apache.ignite.jdbc.IgniteJdbcDriver`.
-This implementation of JDBC driver does not support:
-
-* Multiple endpoints
-* JDBC connection pools
+NOTE: The JDBC driver shipped with Apache Ignite version 3.2 has been
completely reworked to add support for multiple endpoints and
link:developers-guide/clients/overview#partition-awareness[partition awareness].
+However this new driver is not compatible with the previous server versions
(3.1 and 3.0).
+To connect to ignite 3.1 (and 3.0), you must use the previous version of the
driver that shipped with Apache Ignite 3.1.
Review Comment:
The product name should be capitalized consistently. "ignite" should be
"Ignite" (with capital 'I') to match the naming convention used throughout the
documentation.
```suggestion
To connect to Ignite 3.1 (and 3.0), you must use the previous version of the
driver that shipped with Apache Ignite 3.1.
```
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -16,10 +16,10 @@
Apache Ignite is shipped with JDBC driver that allows processing of
distributed data using standard SQL statements like `SELECT`, `INSERT`,
`UPDATE`, or `DELETE` directly from the JDBC side. The name of the driver's
class is `org.apache.ignite.jdbc.IgniteJdbcDriver`.
-This implementation of JDBC driver does not support:
-
-* Multiple endpoints
-* JDBC connection pools
+NOTE: The JDBC driver shipped with Apache Ignite version 3.2 has been
completely reworked to add support for multiple endpoints and
link:developers-guide/clients/overview#partition-awareness[partition awareness].
+However this new driver is not compatible with the previous server versions
(3.1 and 3.0).
Review Comment:
The word "However" should be followed by a comma for proper punctuation. It
should read: "However, this new driver..."
```suggestion
However, this new driver is not compatible with the previous server versions
(3.1 and 3.0).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
