IgGusev commented on code in PR #7040:
URL: https://github.com/apache/ignite-3/pull/7040#discussion_r2565198227
##########
docs/_data/toc.yaml:
##########
@@ -82,8 +82,6 @@
url: developers-guide/sql/calcite-based-sql-engine
- title: SQL API
url: developers-guide/sql/sql-api
- - title: JDBC Driver
- url: developers-guide/sql/jdbc-driver
Review Comment:
Please also delete the file.
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -89,7 +88,9 @@ If the same parameters are passed by using different means,
the JDBC driver prio
== Performing Transactions
-With the JDBC driver, you can perform `commit` and `rollback` transactions.
For more information about transactions, see
link:developers-guide/transactions[Performing Transactions].
+By default a JDBC connection is in auto-commit mode, and in this mode all its
SQL statements will be executed and committed as individual transactions.
Review Comment:
```suggestion
By default, a JDBC connection is in auto-commit mode, and in this mode all
its SQL statements will be executed and committed as individual transactions.
```
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -89,7 +88,9 @@ If the same parameters are passed by using different means,
the JDBC driver prio
== Performing Transactions
-With the JDBC driver, you can perform `commit` and `rollback` transactions.
For more information about transactions, see
link:developers-guide/transactions[Performing Transactions].
+By default a JDBC connection is in auto-commit mode, and in this mode all its
SQL statements will be executed and committed as individual transactions.
+To be able to manage the transaction, you must switch connection to
non-autocommit mode (see
link:https://docs.oracle.com/en/java/javase/11/docs/api/java.sql/java/sql/Connection.html#setAutoCommit(boolean)[java
documentation]).
Review Comment:
Can we add an example here instead of sending user somewhere else?
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -16,10 +16,10 @@
Apache Ignite is shipped with JDBC driver that allows processing of
distributed data using standard SQL statements like `SELECT`, `INSERT`,
`UPDATE`, or `DELETE` directly from the JDBC side. The name of the driver's
class is `org.apache.ignite.jdbc.IgniteJdbcDriver`.
-This implementation of JDBC driver does not support:
-
-* Multiple endpoints
-* JDBC connection pools
+NOTE: The JDBC driver shipped with Apache Ignite version 3.2 has been
completely reworked to add support for multiple endpoints and
link:developers-guide/clients/overview#partition-awareness[partition awareness].
Review Comment:
```suggestion
[NOTE]
====
The JDBC driver was completely reworked in Apache Ignite 3.2 and now
supports multiple endpoints and
link:developers-guide/clients/overview#partition-awareness[partition awareness].
The new driver is not compatible with Apache Ignite 3.1 and 3.0. To connect
to Ignite 3.1 (and 3.0), use the previous version of the driver that was
shipped with Apache Ignite 3.1.
The server part remains compatible with previous versions of the driver, so
driver for Ignite 3.1 can successfully connect to the 3.2 cluster.
====
```
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -16,10 +16,10 @@
Apache Ignite is shipped with JDBC driver that allows processing of
distributed data using standard SQL statements like `SELECT`, `INSERT`,
`UPDATE`, or `DELETE` directly from the JDBC side. The name of the driver's
class is `org.apache.ignite.jdbc.IgniteJdbcDriver`.
-This implementation of JDBC driver does not support:
-
-* Multiple endpoints
-* JDBC connection pools
+NOTE: The JDBC driver shipped with Apache Ignite version 3.2 has been
completely reworked to add support for multiple endpoints and
link:developers-guide/clients/overview#partition-awareness[partition awareness].
Review Comment:
Shipped fits the language of AI 2. Good alternative would be "available".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
