shishkovilja commented on code in PR #12531: URL: https://github.com/apache/ignite/pull/12531#discussion_r2582027897
########## modules/core/src/main/java/org/apache/ignite/internal/IgniteDiagnosticRequest.java: ########## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.LinkedHashMap; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import org.apache.ignite.internal.managers.communication.GridIoMessageFactory; +import org.apache.ignite.internal.util.typedef.internal.S; +import org.apache.ignite.plugin.extensions.communication.Message; +import org.jetbrains.annotations.Nullable; + +/** + * + */ +public class IgniteDiagnosticRequest implements Message { + /** */ + @Order(value = 0, method = "futureId") + private long futId; + + /** Originator node id. */ + @Order(1) + private UUID nodeId; + + /** Infos to send to a remote node. */ + @Order(2) + private Collection<DiagnosticBaseInfo> infos; + + /** Local message related to remote info. */ + private final Map<Object, List<String>> msgs = new LinkedHashMap<>(); + + /** + * Default constructor required by {@link GridIoMessageFactory}. + */ + public IgniteDiagnosticRequest() { + // No-op. + } + + /** + * Creates a diagnostic info holder. + * + * @param nodeId Originator node ID. + */ + IgniteDiagnosticRequest(UUID nodeId) { + this.nodeId = nodeId; + } + + /** + * Creates a diagnostic request. + * + * @param futId Future ID. + * @param nodeId Node ID. + * @param infos Diagnostic infos. + */ + public IgniteDiagnosticRequest(long futId, UUID nodeId, Collection<DiagnosticBaseInfo> infos) { + this(nodeId); + + assert infos != null; + + this.futId = futId; + this.infos = new LinkedHashSet<>(infos); Review Comment: Redundant copying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
