sashapolo commented on code in PR #7101:
URL: https://github.com/apache/ignite-3/pull/7101#discussion_r2597836476
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManager.java:
##########
@@ -533,13 +531,21 @@ private static boolean endOfSegmentReached(ByteBuffer
buffer) {
* possibly incomplete segment file.
*/
private WriteModeIndexMemTable recoverLatestMemtable(SegmentFile
segmentFile, Path segmentFilePath) {
+ return recoverMemtable(segmentFile, segmentFilePath, true);
+ }
+
+ private WriteModeIndexMemTable recoverMemtable(SegmentFile segmentFile,
Path segmentFilePath) {
+ return recoverMemtable(segmentFile, segmentFilePath, false);
Review Comment:
> CRC is not validated here as this is not the latest segment
yes
> and we are sure it's fully synced, right?
No, segment files are synced asynchronously by the log checkpointer.
What comment do you want me to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
