rpuch commented on code in PR #7101:
URL: https://github.com/apache/ignite-3/pull/7101#discussion_r2598682612
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManager.java:
##########
@@ -556,11 +562,24 @@ private WriteModeIndexMemTable
recoverLatestMemtable(SegmentFile segmentFile, Pa
buffer.position(segmentFilePayloadOffset);
// CRC violation signals the end of meaningful data in the
segment file.
- if (!isCrcValid(buffer, crcPosition)) {
+ if (validateCrc && !isCrcValid(buffer, crcPosition)) {
Review Comment:
After thinking about this more, it doesn't seem to bring a lot of value, so
I retract my proposal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
