valepakh commented on code in PR #7083: URL: https://github.com/apache/ignite-3/pull/7083#discussion_r2602372011
########## modules/code-deployment-classloader/src/test/java/org/apache/ignite/internal/deployunit/loader/JobClassLoaderTest.java: ########## Review Comment: Rename to `UnitsClassLoaderTest` ########## modules/code-deployment-classloader/src/test/java/org/apache/ignite/internal/deployunit/loader/JobContextManagerTest.java: ########## Review Comment: Rename to `UnitsContextManagerTest` ########## modules/code-deployment-classloader/src/unit1/java/org/apache/ignite/internal/compute/Job1Utility.java: ########## @@ -0,0 +1,22 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.compute; + +/** Utility class. */ +public class Job1Utility { Review Comment: Looks like this class and `Job2Utililty` are not needed in the `compute` module so they can be moved. And `jobs.gradle` can be cleaned up in that module as well. ########## modules/code-deployment-classloader/src/test/java/org/apache/ignite/internal/deployunit/loader/JobClassLoaderFactoryTest.java: ########## Review Comment: Rename to `UnitsClassLoaderFactoryTest`? ########## modules/code-deployment-classloader/src/main/java/org/apache/ignite/internal/deployunit/loader/UnitsContext.java: ########## @@ -15,25 +15,25 @@ * limitations under the License. */ -package org.apache.ignite.internal.compute.loader; +package org.apache.ignite.internal.deployunit.loader; import java.util.function.Consumer; /** * Job context. */ -public class JobContext implements AutoCloseable { +public class UnitsContext implements AutoCloseable { Review Comment: `UnitsClassLoaderContext`? ########## modules/compute/src/main/java/org/apache/ignite/internal/compute/ClassLoaderExceptionsMapper.java: ########## @@ -34,8 +34,8 @@ class ClassLoaderExceptionsMapper { private static final String DEPLOYMENT_UNIT_NOT_AVAILABLE_MSG = "%s. Deployment unit %s:%s can't be used: " + "[clusterStatus = %s, nodeStatus = %s]"; - static CompletableFuture<JobContext> mapClassLoaderExceptions( - CompletableFuture<JobContext> future, + static CompletableFuture<UnitsContext> mapClassLoaderExceptions( + CompletableFuture<UnitsContext> future, String jobClassName Review Comment: If it's not for the `jobClassName`, I'd say this class should also be moved to the deployment module and exceptions should be mapped inside the `acquireClassLoader` method. Not exactly sure whether we should do this or not. ########## modules/code-deployment-classloader/src/main/java/org/apache/ignite/internal/deployunit/loader/UnitsClassLoaderFactory.java: ########## @@ -15,22 +15,22 @@ * limitations under the License. */ -package org.apache.ignite.internal.compute.loader; +package org.apache.ignite.internal.deployunit.loader; import java.util.List; import org.apache.ignite.internal.deployunit.DisposableDeploymentUnit; /** * Creates a class loader for a job. Review Comment: ```suggestion * Deployment units classloader factory. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
