sanpwc commented on code in PR #7222:
URL: https://github.com/apache/ignite-3/pull/7222#discussion_r2619850405
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -904,12 +868,13 @@ public void beforeNodeStop() {
*/
private CompletableFuture<List<Assignments>>
writeZoneAssignmentsToMetastore(
Review Comment:
`writeZoneAssignmentsToMetastore` is chained to`
getOrCreateAssignments(zoneDescriptor, causalityToken, catalogVersion)` where
we do check whether there are assignments locally and return them if there are.
In other words we do exactly the same as you propose
```
if
(zonePartitionAssignmentsGetLocally(metaStorageMgr, zoneDescriptor.id(), 0,
causalityToken) != null) {
return completedFuture(
zoneAssignmentsGetLocally(
metaStorageMgr,
zoneDescriptor.id(),
zoneDescriptor.partitions(),
causalityToken
)
);
}
```
with same parameters. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
