sanpwc commented on code in PR #7222:
URL: https://github.com/apache/ignite-3/pull/7222#discussion_r2619891947
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -904,12 +868,13 @@ public void beforeNodeStop() {
*/
private CompletableFuture<List<Assignments>>
writeZoneAssignmentsToMetastore(
Review Comment:
Let me elaborate what I mean. If `writeZoneAssignmentsToMetastore` only
updates stable assignments (and I hope it's true), then there's nonneed in
calling `writeZoneAssignmentsToMetastore` if `getOrCreateAssignments` returned
existing assignments instead of calculated new ones. In order to distinguish
whether assignments were calculated or retrieved some refactoring is required,
not big deal though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
