sanpwc commented on code in PR #7313:
URL: https://github.com/apache/ignite-3/pull/7313#discussion_r2647120681
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/replication/PartitionReplicaListenerIndexLockingTest.java:
##########
@@ -422,6 +419,10 @@ void testReadWriteSingle(ReadWriteTestArg arg) {
);
}
+ private static @NotNull ReplicaPrimacy replicaPrimacy() {
+ return
ReplicaPrimacy.forPrimaryReplicaRequest(HybridTimestamp.MIN_VALUE.longValue());
Review Comment:
Here and for other effected tests, for consistency purposes, I'd rather
retrieve leaseStartTime from the PlacementDriver primary replica. Within given
test TestPlacementDriver is used that provides new HybridTimestamp(0L, 1); It
just looks a bit more robust.
##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItTxDistributedTestSingleNodeNoCleanupMessage.java:
##########
@@ -204,33 +198,16 @@ protected PartitionReplicaListener newReplicaListener(
transactionStateResolver,
storageUpdateHandler,
validationSchemasSource,
- localNode,
schemaSyncService,
catalogService,
- placementDriver,
clusterNodeResolver,
resourcesRegistry,
schemaRegistry,
mock(IndexMetaStorage.class),
lowWatermark,
mock(FailureProcessor.class),
new
TableMetricSource(QualifiedName.fromSimple("test_table"))
- ) {
- @Override
- public CompletableFuture<ReplicaResult>
invoke(ReplicaRequest request, UUID senderId) {
- if (request instanceof
WriteIntentSwitchReplicaRequest) {
- logger().info("Dropping cleanup request: {}",
request);
-
- releaseTxLocks(
Review Comment:
Curious how it's possible for the tests to pass if the logic was removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
