rpuch commented on code in PR #7313:
URL: https://github.com/apache/ignite-3/pull/7313#discussion_r2647160213
##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItTxDistributedTestSingleNodeNoCleanupMessage.java:
##########
@@ -204,33 +198,16 @@ protected PartitionReplicaListener newReplicaListener(
transactionStateResolver,
storageUpdateHandler,
validationSchemasSource,
- localNode,
schemaSyncService,
catalogService,
- placementDriver,
clusterNodeResolver,
resourcesRegistry,
schemaRegistry,
mock(IndexMetaStorage.class),
lowWatermark,
mock(FailureProcessor.class),
new
TableMetricSource(QualifiedName.fromSimple("test_table"))
- ) {
- @Override
- public CompletableFuture<ReplicaResult>
invoke(ReplicaRequest request, UUID senderId) {
- if (request instanceof
WriteIntentSwitchReplicaRequest) {
- logger().info("Dropping cleanup request: {}",
request);
-
- releaseTxLocks(
Review Comment:
I guess the test does not test what it was intended to test for some time
(months?). I ran it on main, and the overridden `invoke()` is never called.
I will file an issue about this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
