ivanzlenko commented on code in PR #7374:
URL: https://github.com/apache/ignite-3/pull/7374#discussion_r2676324060
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/DataRegion.java:
##########
@@ -25,4 +25,9 @@ public interface DataRegion<T extends PageMemory> {
* Returns page memory.
*/
T pageMemory();
+
+ /**
+ * Returns the region size in bytes.
+ */
+ long regionSize();
Review Comment:
Interface is an abstraction describing a specific object with specific
behavior. In that case we a Data Region which can tell it's own size. You are
proposing, since we are not checking the size of an object directly in tests to
not disclose this behavior directly and instead cast to specific implementation
every time we need to get a size. However all actual implementations have this
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
