tkalkirill commented on code in PR #7374:
URL: https://github.com/apache/ignite-3/pull/7374#discussion_r2676354240
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/DataRegion.java:
##########
@@ -25,4 +25,9 @@ public interface DataRegion<T extends PageMemory> {
* Returns page memory.
*/
T pageMemory();
+
+ /**
+ * Returns the region size in bytes.
+ */
+ long regionSize();
Review Comment:
By adding a new method, you're effectively using it for two implementations;
it's not needed for the others, and this introduces more changes than
necessary. Furthermore, this method is used strictly in two places where a
common contract isn't needed. I suggest not introducing a new method to avoid
introducing too many changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
