ascherbakoff commented on code in PR #7449:
URL: https://github.com/apache/ignite-3/pull/7449#discussion_r2712178390
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/tx/ClientTransactionRollbackRequest.java:
##########
@@ -70,6 +73,15 @@ public static CompletableFuture<ResponseWriter> process(
merge(table.internalTable(), partId, consistentId, token,
tx, false);
}
}
+
+ if (cnt > 0) {
+ in.unpackLong(); // Unpack causality.
+
+ ReadWriteTransactionImpl tx0 = (ReadWriteTransactionImpl) tx;
+
+ // Enforce cleanup.
+ tx0.noRemoteWrites(sendRemoteWritesFlag && in.unpackBoolean());
Review Comment:
I considered and discarded this idea, because it doesn't make sense for RO
txns, as you noted.
Current solution is not the best also, but looks better, because involves
less code changes.
The proper solution is to refactor InternalTransaction for RW and RO cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
