ascherbakoff commented on code in PR #7449:
URL: https://github.com/apache/ignite-3/pull/7449#discussion_r2712190106
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/tx/ClientTransactionCommitRequest.java:
##########
@@ -83,8 +86,13 @@ public static CompletableFuture<ResponseWriter> process(
if (cnt > 0) {
long causality = in.unpackLong();
- // Update causality.
+ // Update causality. Used to assign commit timestamp after all
enlistments.
clockService.updateClock(HybridTimestamp.hybridTimestamp(causality));
+
+ ReadWriteTransactionImpl tx0 = (ReadWriteTransactionImpl) tx;
+
+ // Enforce cleanup.
+ tx0.noRemoteWrites(sendRemoteWritesFlag && in.unpackBoolean());
Review Comment:
valid point, moved under `if` condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
