alievmirza commented on code in PR #7445:
URL: https://github.com/apache/ignite-3/pull/7445#discussion_r2727676623
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/distributed/disaster/ItHighAvailablePartitionsRecoveryByFilterUpdateTest.java:
##########
Review Comment:
`assertLogicalTopologyInMetastorage(List.of(0, 3, 4, 5), node);`
##########
modules/transactions/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryReconfigurationTest.java:
##########
@@ -808,19 +808,21 @@ void testAutomaticRebalanceIfMajorityIsLost() throws
Exception {
awaitPrimaryReplica(node0, partId);
- assertRealAssignments(node0, partId, 1);
+ assertRealAssignments(node0, partId, 0, 1, 2);
List<Throwable> errors = insertValues(table, partId, 0);
assertThat(errors, is(empty()));
// Check that there is no ongoing or planned rebalance.
assertNull(getPendingAssignments(node0, partId));
- assertRealAssignments(node0, partId, 1);
Review Comment:
let's also check scenario when offline nodes where filtered (in this case,
node 2 also was removed)
##########
modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/AssignmentsQueue.java:
##########
@@ -41,6 +41,15 @@ public class AssignmentsQueue implements
Iterable<Assignments> {
@IgniteToStringInclude
private final Deque<Assignments> queue;
+ /** Constructor. */
+ public AssignmentsQueue(AssignmentsQueue... assignmentsQueues) {
+ LinkedList<Assignments> assigments = new LinkedList<>();
Review Comment:
typo
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequestHandler.java:
##########
@@ -333,7 +333,17 @@ private static CompletableFuture<Integer> partitionUpdate(
.stable(Assignments.of(currentAssignments,
assignmentsTimestamp))
.target(Assignments.forced(Set.of(nextAssignment),
assignmentsTimestamp))
.toQueue();
-
+ if (!manualUpdate) {
Review Comment:
Let think about this zhopniy scenario
```
A(10), B(10), C(6)
A, B left
C leader -> we have pending realance that include A or B [A, B, C, E(0)]
C accepts some data -> C(10')
A, B restarted, they wont clean up their data
A(10), B(10), C(10'), E(10')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
