adityamukho commented on code in PR #7553: URL: https://github.com/apache/ignite-3/pull/7553#discussion_r2781429696
########## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/StoragePartitionMetaIoV3.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.storage.pagememory; + +import static org.apache.ignite.internal.pagememory.util.PageUtils.getLong; +import static org.apache.ignite.internal.pagememory.util.PageUtils.putLong; + +import org.apache.ignite.internal.pagememory.util.PageIdUtils; + +/** Storage Io for partition metadata pages (version 3). */ +public class StoragePartitionMetaIoV3 extends StoragePartitionMetaIo { + private static final int WI_HEAD_OFF = ESTIMATED_SIZE_OFF + Long.BYTES; Review Comment: I think the reason why we got this wrong the first time was because it is easy to miss what the second addition operand represents. This is probably a good time to come up with a way to more tightly bind the estimated size and its size representation together (along with other, similar meta entities) - either by defining new constants separately, or grouped together in an `enum`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
