rpuch commented on code in PR #7553:
URL: https://github.com/apache/ignite-3/pull/7553#discussion_r2782677380
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/StoragePartitionMetaIo.java:
##########
@@ -78,6 +106,10 @@ protected StoragePartitionMetaIo(int ver) {
@Override
public void initNewPage(long pageAddr, long pageId, int pageSize) {
+ initMetaIoV1(pageAddr, pageId, pageSize);
+ }
+
+ protected void initMetaIoV1(long pageAddr, long pageId, int pageSize) {
Review Comment:
Let's make the method final
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/StoragePartitionMetaIoV3.java:
##########
@@ -54,4 +55,11 @@ public void setWiHead(long pageAddr, long headLink) {
public long getWiHead(long pageAddr) {
return getLong(pageAddr, WI_HEAD_OFF);
}
+
+ // WI head link overlapped with first 4 bytes of estimated size field, but
we assume that there were no partitions with 4b rows and
Review Comment:
Why do we still need this comment here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
