timoninmaxim commented on code in PR #12710:
URL: https://github.com/apache/ignite/pull/12710#discussion_r2783586277
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientChannel.java:
##########
@@ -736,7 +740,7 @@ private void handshake(ProtocolVersion ver, String user,
String pwd, Map<String,
handshakeReq(ver, user, pwd, userAttrs);
try {
- ByteBuffer buf = timeout > 0 ? fut.get(timeout) : fut.get();
+ ByteBuffer buf = connTimeout > 0 ? fut.get(connTimeout) :
fut.get();
Review Comment:
Actually, there is a misleading behavior. We call
`eventListener.onHandshakeStart(ver)` before the loop, but may retry handshake
with different `ver`. At the same time we log "Handshake failed" for each
attempt.
I suppose that we should move `eventListener.onHandshakeStart` within the
loop, to fix the `ver` it notifies. In this context `handshakeTimeout` is OK.
WDYT about this? Should we investigate moving of this call within this
ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
