timoninmaxim commented on code in PR #12710:
URL: https://github.com/apache/ignite/pull/12710#discussion_r2787494530
##########
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java:
##########
@@ -227,18 +231,65 @@ public ClientConfiguration setTcpNoDelay(boolean
tcpNoDelay) {
}
/**
- * @return Send/receive timeout in milliseconds.
+ * @deprecated Use {@link #getHandshakeTimeout()} and {@link
#getRequestTimeout()} instead.
+ * @return Request timeout in milliseconds.
*/
+ @Deprecated
public int getTimeout() {
- return timeout;
+ if (reqTimeout != handshakeTimeout) {
+ U.warn(logger, String.format(
+ "Deprecated getTimeout() API is used while request timeout
(%d) differs from handshake timeout (%d). " +
+ "Returning request timeout. Please use getRequestTimeout()
and getHandshakeTimeout() instead.",
+ reqTimeout, handshakeTimeout
+ ));
+ }
Review Comment:
@ptupitsyn yes, I'm fixing it. Thanks for calling the agent :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
