nizhikov commented on code in PR #12642:
URL: https://github.com/apache/ignite/pull/12642#discussion_r2797672712
##########
modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java:
##########
@@ -1651,8 +1653,12 @@ private void addDataStorageConfigurationAttributes()
throws IgniteCheckedExcepti
add(ATTR_MEMORY_CONFIG, memCfg);
}
+ DataStorageConfiguration dsCfg = cfg.getDataStorageConfiguration();
+
// Save data storage configuration.
- add(ATTR_DATA_STORAGE_CONFIG,
ctx.marshallerContext().jdkMarshaller().marshal(cfg.getDataStorageConfiguration()));
+ add(ATTR_DATA_STORAGE_CONFIG,
ctx.marshallerContext().jdkMarshaller().marshal(dsCfg));
+
+ ctx.addNodeAttribute(ATTR_WAL_MODE, dsCfg == null ? null :
dsCfg.getWalMode().ordinal());
Review Comment:
Why do we need to store WAL_MODE explicitly?
Can we take value from `ATTR_DATA_STORAGE_CONFIG` which save in attributes
line above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
