nizhikov commented on code in PR #12642:
URL: https://github.com/apache/ignite/pull/12642#discussion_r2803201485
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java:
##########
@@ -2173,6 +2188,27 @@ private DiscoCache resolveDiscoCache(int grpId,
AffinityTopologyVersion topVer)
return cache;
}
+ /**
+ * Extracts WAL mode from marshalled Data Storage Configuration
+ * @param dsCfgBytes Marshalled Data Storage Configuration
+ * @return WAL mode stored in dsCfg or {@code null} if unmarshalling
failed or got null dsCfg
+ */
+ private WALMode
ExtractWalModeFromDataStorageConfigurationMarshalled(Object dsCfgBytes) {
Review Comment:
Let's rename this `ExtractWalModeFromDataStorageConfigurationMarshalled` to
`nodeWalMode` and make argument `ClusterNode`
`private WALMode nodeWalMode(ClusterNode n)`
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java:
##########
@@ -2173,6 +2188,27 @@ private DiscoCache resolveDiscoCache(int grpId,
AffinityTopologyVersion topVer)
return cache;
}
+ /**
+ * Extracts WAL mode from marshalled Data Storage Configuration
+ * @param dsCfgBytes Marshalled Data Storage Configuration
+ * @return WAL mode stored in dsCfg or {@code null} if unmarshalling
failed or got null dsCfg
+ */
+ private WALMode
ExtractWalModeFromDataStorageConfigurationMarshalled(Object dsCfgBytes) {
Review Comment:
Let's rename `ExtractWalModeFromDataStorageConfigurationMarshalled` to
`nodeWalMode` and make argument `ClusterNode`
`private WALMode nodeWalMode(ClusterNode n)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
