alex-plekhanov commented on code in PR #12726:
URL: https://github.com/apache/ignite/pull/12726#discussion_r2802842493
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/StdSqlOperatorsTest.java:
##########
@@ -275,6 +275,17 @@ public void testPosixRegex() {
assertExpression("REGEXP_REPLACE('aAaA', '[Aa]+', 'X',
2)").returns("aX").check();
assertExpression("REGEXP_REPLACE('aAbaAcaA', '[Aa]+', 'X', 2,
2)").returns("aAbXcaA").check();
assertExpression("REGEXP_REPLACE('aAbaAcaA', 'a', 'X', 2, 0,
'i')").returns("aXbXXcXX").check();
+ assertExpression("REGEXP_SUBSTR('hello world',
'l.o')").returns("llo").check();
Review Comment:
This class is not for testing all cases, see javadoc. Only one case per
implementor in this class please. Other cases can be moved to some other
classes.
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/sql/fun/IgniteStdSqlOperatorTable.java:
##########
@@ -230,6 +230,8 @@ public IgniteStdSqlOperatorTable() {
register(SqlLibraryOperators.REGEXP_REPLACE_4);
register(SqlLibraryOperators.REGEXP_REPLACE_5_ORACLE);
register(SqlLibraryOperators.REGEXP_REPLACE_6);
+ register(SqlLibraryOperators.REGEXP_SUBSTR);
+ register(SqlLibraryOperators.REGEXP_EXTRACT);
Review Comment:
Let's add only REGEXP_SUBSTR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
