alex-plekhanov commented on code in PR #12726:
URL: https://github.com/apache/ignite/pull/12726#discussion_r2803550387
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/sql/fun/IgniteStdSqlOperatorTable.java:
##########
@@ -230,6 +230,8 @@ public IgniteStdSqlOperatorTable() {
register(SqlLibraryOperators.REGEXP_REPLACE_4);
register(SqlLibraryOperators.REGEXP_REPLACE_5_ORACLE);
register(SqlLibraryOperators.REGEXP_REPLACE_6);
+ register(SqlLibraryOperators.REGEXP_SUBSTR);
+ register(SqlLibraryOperators.REGEXP_EXTRACT);
Review Comment:
REGEXP_EXTRACT not in standard
REGEXP_EXTRACT not used by major DB vendors except BigQuery
Built-in function is a public API, and add duplicated functionality to
public API it's not a good idea, we need to support more functions in the
future and can't remove it (we already have made such a mistake with LENGTH,
CHAR_LENGTH, CHARACTER_LENGTH or some other functions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
