AMashenkov commented on code in PR #7588:
URL: https://github.com/apache/ignite-3/pull/7588#discussion_r2846586407
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/tx/ClientTransactionBeginRequest.java:
##########
@@ -63,6 +68,14 @@ public static CompletableFuture<ResponseWriter> process(
InternalTxOptions txOptions = InternalTxOptions.builder()
.timeoutMillis(timeoutMillis)
.readTimestamp(observableTs)
+ .killClosure(tx -> {
+ if (notificationSender != null) {
+ // Exception will be ignored if a client doesn't
support it.
+ TransactionKilledException err = new
TransactionKilledException(tx.id(), txManager);
+
+ notificationSender.sendNotification(w -> {}, err,
NULL_HYBRID_TIMESTAMP);
+ }
Review Comment:
```suggestion
.killClosure((notificationSender == null)
? tx -> {} // Exception will be ignored if a client
doesn't support it.
: tx -> {
TransactionKilledException err = new
TransactionKilledException(tx.id(), txManager);
notificationSender.sendNotification(w -> {}, err,
NULL_HYBRID_TIMESTAMP);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
