AMashenkov commented on code in PR #7588:
URL: https://github.com/apache/ignite-3/pull/7588#discussion_r2846751997
##########
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientLazyTransaction.java:
##########
@@ -92,14 +93,7 @@ public CompletableFuture<Void> commitAsync() {
@Override
public void rollback() throws TransactionException {
- var tx0 = tx;
-
- if (tx0 == null) {
- // No operations were performed, nothing to rollback.
- return;
- }
-
- tx0.join().rollback();
+ rollbackAsync().join();
Review Comment:
AFAIR, we agree to avoid usage `join()` for futures that may be incomplete,
because it is uninterruptable.
So, we've implemented `ViewUtils.sync(CompletableFuture<T> fut)`.
I see this approach used in the whole class and should be fixed in another
ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
