ascherbakoff commented on code in PR #7588:
URL: https://github.com/apache/ignite-3/pull/7588#discussion_r2851629956
##########
modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -468,6 +468,9 @@ public static class Transactions {
/** Operation failed due to replication delayed ack failure. */
public static final int TX_DELAYED_ACK_ERR =
TX_ERR_GROUP.registerErrorCode((short) 17);
+
+ /** Transaction was internally killed. This is retriable state. */
Review Comment:
It's retriable in terms of `runInTransaction` retry check, based on marker
interface.
This code is added by you.
`TransactionKilledException `is marked with `RetriableTransactionException`.
##########
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientLazyTransaction.java:
##########
@@ -92,14 +93,7 @@ public CompletableFuture<Void> commitAsync() {
@Override
public void rollback() throws TransactionException {
- var tx0 = tx;
-
- if (tx0 == null) {
- // No operations were performed, nothing to rollback.
- return;
- }
-
- tx0.join().rollback();
+ rollbackAsync().join();
Review Comment:
Wrapped commit and rollback future in `ViewUtils.sync`. This should be
enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
