shishkovilja commented on code in PR #12754:
URL: https://github.com/apache/ignite/pull/12754#discussion_r2882835710
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageCasMessage.java:
##########
@@ -18,26 +18,36 @@
package org.apache.ignite.internal.processors.metastorage.persistence;
import java.util.UUID;
+import org.apache.ignite.internal.Order;
import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.DiscoveryMessageFactory;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.jetbrains.annotations.Nullable;
/** */
-class DistributedMetaStorageCasMessage extends
DistributedMetaStorageUpdateMessage {
+public class DistributedMetaStorageCasMessage extends
DistributedMetaStorageUpdateMessage {
/** */
private static final long serialVersionUID = 0L;
/** */
- private final byte[] expectedVal;
+ @Order(0)
+ byte[] expectedVal;
Review Comment:
Please, add TODO to refactor bytes, which are serialized externally.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageUpdateMessage.java:
##########
@@ -18,39 +18,50 @@
package org.apache.ignite.internal.processors.metastorage.persistence;
import java.util.UUID;
+import org.apache.ignite.internal.Order;
import org.apache.ignite.internal.managers.discovery.DiscoCache;
import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.managers.discovery.DiscoveryMessageFactory;
import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager;
import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
import org.apache.ignite.internal.util.tostring.GridToStringInclude;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.lang.IgniteUuid;
+import org.apache.ignite.plugin.extensions.communication.Message;
import org.jetbrains.annotations.Nullable;
/** */
-class DistributedMetaStorageUpdateMessage implements DiscoveryCustomMessage {
+public class DistributedMetaStorageUpdateMessage implements
DiscoveryCustomMessage, Message {
/** */
private static final long serialVersionUID = 0L;
/** */
- private final IgniteUuid id = IgniteUuid.randomUuid();
+ @Order(0)
+ IgniteUuid id;
/** Request ID. */
+ @Order(1)
@GridToStringInclude
- private final UUID reqId;
+ UUID reqId;
/** */
+ @Order(2)
@GridToStringInclude
- private final String key;
+ String key;
/** */
- private final byte[] valBytes;
+ @Order(3)
+ byte[] valBytes;
Review Comment:
Please, add TODO to refactor bytes, which are serialized externally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
