shishkovilja commented on code in PR #12754:
URL: https://github.com/apache/ignite/pull/12754#discussion_r2911653683
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageUpdateAckMessage.java:
##########
@@ -53,16 +63,30 @@ public UUID requestId() {
return reqId;
}
- /** */
- public String errorMessage() {
- return errorMsg;
- }
-
/** {@inheritDoc} */
@Override @Nullable public DiscoveryCustomMessage ackMessage() {
return null;
}
+ /** {@inheritDoc} */
+ @Override public boolean isMutable() {
Review Comment:
Duplicates behavior of `DiscoveryCustomMessage#isMutable`
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageUpdateAckMessage.java:
##########
@@ -53,16 +63,30 @@ public UUID requestId() {
return reqId;
}
- /** */
- public String errorMessage() {
- return errorMsg;
- }
-
/** {@inheritDoc} */
@Override @Nullable public DiscoveryCustomMessage ackMessage() {
return null;
}
+ /** {@inheritDoc} */
+ @Override public boolean isMutable() {
+ return false;
+ }
+
+ /** {@inheritDoc} */
+ @Override public DiscoCache createDiscoCache(
Review Comment:
Duplicates behavior of `DiscoveryCustomMessage#createDiscoCache`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
