Lalant commented on code in PR #7482:
URL: https://github.com/apache/ignite-3/pull/7482#discussion_r2883259981
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/IgniteAbstractTransactionImpl.java:
##########
@@ -164,4 +167,12 @@ public long getTimeout() {
public boolean isRolledBackWithTimeoutExceeded() {
return timeoutExceeded;
}
+
+ @Override
+ public CompletableFuture<Void> rollbackWithExceptionAsync(Throwable
throwable) {
+ return TransactionsExceptionMapperUtil.convertToPublicFuture(
+ finish(false, null, false, throwable),
+ isFinishedDueToTimeout(throwable) ?
TX_ALREADY_FINISHED_WITH_TIMEOUT_ERR : TX_ROLLBACK_ERR
Review Comment:
Fixed
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -670,14 +672,19 @@ private <R> CompletableFuture<R> trackingInvoke(
code = TX_ALREADY_FINISHED_WITH_TIMEOUT_ERR;
}
+ Throwable cause = lastException(tx.id());
+
return failedFuture(
new TransactionException(code, format(
- "Transaction is already finished
[tableName={}, partId={}, txState={}, timeoutExceeded={}].",
+ (code ==
TX_ALREADY_FINISHED_WITH_TIMEOUT_ERR
+ ?
TX_ALREADY_FINISHED_DUE_TO_TIMEOUT
+ : TX_ALREADY_FINISHED)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
