Lalant commented on code in PR #7482:
URL: https://github.com/apache/ignite-3/pull/7482#discussion_r2883269297
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImpl.java:
##########
@@ -136,10 +138,10 @@ public CompletableFuture<Void> finish(
boolean commitIntent,
HybridTimestamp executionTimestamp,
boolean full,
- boolean timeoutExceeded
+ @Nullable Throwable finishReason
) {
assert !full : "Read-only transactions cannot be full.";
- assert !(commitIntent && timeoutExceeded) : "Transaction cannot commit
with timeout exceeded.";
+ assert !(commitIntent && finishReason != null) : "Transaction cannot
commit with a finish reason.";
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
