Vladsz83 commented on code in PR #12827:
URL: https://github.com/apache/ignite/pull/12827#discussion_r2891276978
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java:
##########
@@ -152,6 +178,9 @@ public class DiscoveryMessageFactory implements
MessageFactoryProvider {
factory.register((short)21, TcpDiscoveryCustomEventMessage::new, new
TcpDiscoveryCustomEventMessageSerializer());
factory.register((short)22,
TcpDiscoveryServerOnlyCustomEventMessage::new,
new TcpDiscoveryServerOnlyCustomEventMessageSerializer());
+ factory.register((short)23, FullMessage::new, new
FullMessageSerializer());
+
Review Comment:
Why spaced and exactly 86? No 24? Or 100? No comment on this?
##########
modules/core/src/main/java/org/apache/ignite/internal/util/distributed/SingleNodeMessage.java:
##########
@@ -34,23 +33,27 @@
* @see FullMessage
* @see InitMessage
*/
-public class SingleNodeMessage<R extends Serializable> implements Message {
+public class SingleNodeMessage<R extends Message> implements Message {
/** Initial channel message type (value is {@code 176}). */
public static final short TYPE_CODE = 176;
/** Process id. */
- private UUID processId;
+ @Order(0)
+ UUID processId;
/** Process type. */
- private int type;
+ @Order(1)
+ int type;
/** Single node response. */
- private R resp;
+ @Order(value = 2, method = "response")
+ private Message resp;
/** Error. */
- private Throwable err;
+ @Order(3)
+ @Nullable ErrorMessage errMsg;
- /** Empty constructor for marshalling purposes. */
+ /** Default constructor for {@link GridIoMessageFactory}. */
Review Comment:
Trivial codestyle: let's put `// No-op.`
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java:
##########
@@ -168,5 +197,17 @@ public class DiscoveryMessageFactory implements
MessageFactoryProvider {
new TxTimeoutOnPartitionMapExchangeChangeMessageSerializer());
factory.register((short)510, UserAcceptedMessage::new, new
UserAcceptedMessageSerializer());
factory.register((short)511, UserProposedMessage::new, new
UserProposedMessageSerializer());
+
+ factory.register((short)520, SnapshotOperationResponse::new, new
SnapshotOperationResponseSerializer());
Review Comment:
Are they custom messages? I believe we've met a problem of the messages
sharing between Discovery and Communication. This wasn't significant until the
shared messages number exceeds 5 maybe. The messages sharing should be
discussed. We might introduce a message number replacement at the message
registering. Or even use a message-content-generated hash/id to exclude the
manual-processed numbers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
