Vladsz83 commented on code in PR #12827:
URL: https://github.com/apache/ignite/pull/12827#discussion_r2897945393
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java:
##########
@@ -168,5 +197,17 @@ public class DiscoveryMessageFactory implements
MessageFactoryProvider {
new TxTimeoutOnPartitionMapExchangeChangeMessageSerializer());
factory.register((short)510, UserAcceptedMessage::new, new
UserAcceptedMessageSerializer());
factory.register((short)511, UserProposedMessage::new, new
UserProposedMessageSerializer());
+
+ factory.register((short)520, SnapshotOperationResponse::new, new
SnapshotOperationResponseSerializer());
Review Comment:
Consider the case when id of a shared message is already occupied in
Discovery and you can't reuse. I belive that using of ids from one domain
should not be "as is" in other domain where messages and their numeration are
different by nature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
