EgorKuts commented on code in PR #7731:
URL: https://github.com/apache/ignite-3/pull/7731#discussion_r2905121813
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -2638,6 +2638,9 @@ public Message handleAppendEntriesRequest(final
AppendEntriesRequest request, fi
done,
this.currTerm
);
+ if (request.timestamp() != null) {
+ clock.update(request.timestamp());
Review Comment:
No. If the leader has the most advanced clock, it is possible for the new
leader to have a stale clock value. This scenario is shown in the reproducer (2
out of 3 nodes have a lower HLC).
If we need to address the contention, I propose creating a separate clock
per partition. This clock would be updated on each appendEntry and merged with
the main clock when the node becomes a leader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
