ascherbakoff commented on code in PR #7731:
URL: https://github.com/apache/ignite-3/pull/7731#discussion_r2909700993
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -2638,6 +2638,9 @@ public Message handleAppendEntriesRequest(final
AppendEntriesRequest request, fi
done,
this.currTerm
);
+ if (request.timestamp() != null) {
+ clock.update(request.timestamp());
Review Comment:
Safe timestamp is already passed with each group command.
Can we just propagate it's value to a node's clock to ensure monotonic
invariant, like this:
```
if (safeTimestamp != null) {
clock.update(safeTimestamp);
try {
safeTimeTracker.update(safeTimestamp,
commandIndex, commandTerm, command);
} catch (TrackerClosedException ignored) {
// Ignored.
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
