zstan commented on code in PR #12796:
URL: https://github.com/apache/ignite/pull/12796#discussion_r2910143551
##########
modules/web/src/main/java/org/apache/ignite/cache/websession/WebSession.java:
##########
@@ -248,8 +248,10 @@ protected void setId(String id) {
return val;
}
- /** {@inheritDoc} */
- @Override public Object getValue(String name) {
+ /**
+ * @deprecated Legacy {@link HttpSession} API. Use {@link
#getAttribute(String)}.
+ */
+ @Deprecated public Object getValue(String name) {
Review Comment:
seems `@Override `still need to be present here
##########
modules/web/src/main/java/org/apache/ignite/cache/websession/WebSession.java:
##########
@@ -261,8 +263,10 @@ protected void setId(String id) {
return Collections.enumeration(attrs.keySet());
}
- /** {@inheritDoc} */
- @Override public String[] getValueNames() {
+ /**
+ * @deprecated Legacy {@link HttpSession} API. Use {@link
#getAttributeNames()}.
+ */
+ @Deprecated public String[] getValueNames() {
Review Comment:
seems `@Override` still need to be present here
##########
modules/web/src/main/java/org/apache/ignite/cache/websession/WebSession.java:
##########
@@ -280,8 +284,10 @@ protected void setId(String id) {
updates.add(new T2<>(name, val));
}
- /** {@inheritDoc} */
- @Override public void putValue(String name, Object val) {
+ /**
+ * @deprecated Legacy {@link HttpSession} API. Use {@link
#setAttribute(String, Object)}.
+ */
+ @Deprecated public void putValue(String name, Object val) {
Review Comment:
seems `@Override `still need to be present here, the same for below
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotSelfTest.java:
##########
@@ -1309,6 +1309,9 @@ public void testClientHandlesSnapshotFailOnStartStage()
throws Exception {
ClusterTopologyException.class,
"Snapshot operation interrupted, because baseline node left the
cluster");
+ // Wait for partition map exchange to finish after node left.
+ awaitPartitionMapExchange();
+
// Check that client node is alive.
assertSnapshotCacheKeys(cln.cache(dfltCacheCfg.getName()));
Review Comment:
this is a valid user operation and if awaiting PME is required here for some
reason it looks like a bug and appropriate issue need to be filled. I run it
locally and found a different hang (fill an issue)
https://issues.apache.org/jira/browse/IGNITE-28115
Thus i think _awaitPartitionMapExchange_ need to be removed and if it
required - additional issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
