alievmirza commented on code in PR #7722:
URL: https://github.com/apache/ignite-3/pull/7722#discussion_r2958861697
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/FSMCallerImpl.java:
##########
@@ -69,29 +70,28 @@ public class FSMCallerImpl implements FSMCaller {
private static final IgniteLogger LOG =
Loggers.forClass(FSMCallerImpl.class);
+ private final MetricManager metricManager;
+
/**
* Task type
*/
public enum TaskType {
- IDLE, //
- COMMITTED, //
- SNAPSHOT_SAVE, //
- SNAPSHOT_LOAD, //
- LEADER_STOP, //
- LEADER_START, //
- START_FOLLOWING, //
- STOP_FOLLOWING, //
- SHUTDOWN, //
- FLUSH, //
- ERROR;
-
- private String metricName;
-
- public String metricName() {
- if (this.metricName == null) {
- this.metricName = "fsm-" +
name().toLowerCase().replaceAll("_", "-");
- }
- return this.metricName;
+ IDLE ("IdleDuration"),
Review Comment:
These are FSMCaller task types, so they have nothing in common with
"...Duration". Why did you name them this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
