tmgodinho commented on code in PR #7844:
URL: https://github.com/apache/ignite-3/pull/7844#discussion_r3010265972
##########
modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java:
##########
@@ -377,6 +381,18 @@ public <T> CompletableFuture<AsyncResultSet<T>>
executeAsyncInternal(
tx.recordOperationFailure(err);
}
+ // We should reconcile this code with ClientTable. Should be
the same.
Review Comment:
Yes, I also think it would be best.
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -292,6 +293,25 @@ public class ClientInboundMessageHandler
private final HandshakeEventLoopSwitcher handshakeEventLoopSwitcher;
+ /**
+ * Tracks mappings between the first {@code requestId} and the {@code
resourceId}
+ * holding the Tx object for directly mapped transactions. The process is
not localized.
+ *
+ * <p><b>Mappings are created:</b>
+ * <ul>
+ * <li>When a direct transaction is created in {@link
ClientTableCommon#readTx(ClientMessageUnpacker, HybridTimestampTracker,
+ * ClientResourceRegistry, TxManager, IgniteTables,
NotificationSender, long[], long, Map)}.
+ * </li>
+ * </ul>
+ *
+ * <p><b>Mappings are removed:</b>
+ * <ul>
+ * <li>During a rollback request.</li>
+ * <li>After the first request response is sent to the client.</li>
Review Comment:
No, forgot to hcnage it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
