ptupitsyn commented on code in PR #7844:
URL: https://github.com/apache/ignite-3/pull/7844#discussion_r2973810283
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -1200,6 +1225,8 @@ private void processOperationInternal(
writeError(requestId, opCode, e, ctx, false);
metrics.requestsFailedIncrement();
}
+
+ firstReqToTxResMap.remove(requestId);
Review Comment:
Here we remove the mapping once the response is sent, but the client might
have requested cancellation just before it received our response:
```
client: send request
server: firstReqToTxResMap.add
server: send response, `firstReqToTxResMap.remove`
client: cancel operation
server: returns an error?
```
Can we remove the `firstReqToTxResMap` later? For example, when the tx is
cleaned up (removed from the resource registry)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
