tkalkirill commented on code in PR #12926: URL: https://github.com/apache/ignite/pull/12926#discussion_r3025820334
########## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexWrappedKeyScan.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.query.calcite.exec; + +import java.util.Map; +import org.apache.calcite.util.ImmutableBitSet; +import org.apache.calcite.util.ImmutableIntList; +import org.apache.ignite.binary.BinaryObject; +import org.apache.ignite.internal.cache.query.index.sorted.IndexKeyDefinition; +import org.apache.ignite.internal.cache.query.index.sorted.IndexKeyType; +import org.apache.ignite.internal.cache.query.index.sorted.IndexPlainRowImpl; +import org.apache.ignite.internal.cache.query.index.sorted.IndexRow; +import org.apache.ignite.internal.cache.query.index.sorted.InlineIndexRowHandler; +import org.apache.ignite.internal.cache.query.index.sorted.inline.InlineIndex; +import org.apache.ignite.internal.cache.query.index.sorted.keys.IndexKey; +import org.apache.ignite.internal.cache.query.index.sorted.keys.IndexKeyFactory; +import org.apache.ignite.internal.processors.query.QueryUtils; +import org.apache.ignite.internal.processors.query.calcite.exec.exp.RangeIterable; +import org.apache.ignite.internal.processors.query.calcite.schema.CacheTableDescriptor; +import org.apache.ignite.internal.processors.query.calcite.schema.ColumnDescriptor; +import org.apache.ignite.internal.processors.query.calcite.util.TypeUtils; +import org.jetbrains.annotations.Nullable; + +/** Extension for column {@value QueryUtils#KEY_FIELD_NAME} in case of composite primary key. */ +public class IndexWrappedKeyScan<Row> extends IndexScan<Row> { + /** */ + public IndexWrappedKeyScan( + ExecutionContext<Row> ectx, + CacheTableDescriptor desc, + InlineIndex idx, + ImmutableIntList idxFieldMapping, + int[] parts, + RangeIterable<Row> ranges, + @Nullable ImmutableBitSet requiredColumns + ) { + super(ectx, desc, idx, idxFieldMapping, parts, ranges, requiredColumns); + } + + /** */ + @Override protected IndexRow row2indexRow(Row bound) { + if (bound == null) + return null; + + RowHandler<Row> rowHnd = ectx.rowHandler(); + + Object key = rowHnd.get(QueryUtils.KEY_COL, bound); + assert key != null : String.format("idxName=%s, bound=%s", idx.name(), rowHnd.toString(bound)); + + if (key instanceof BinaryObject) + return binaryObject2indexRow((BinaryObject)key); + + // TODO: IGNITE-28374 Implement for POJO key class + return super.row2indexRow(bound); Review Comment: Yes, I did that, but the previous reviewer asked me not to do it because it hadn't happened before. I also think it's worth throwing an exception, since that won't work correctly. It's better to see an error than an unexpected result. I'll rework it to reflect the error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
